From de442491d9bfb04b841f6a80edffcdfbb982dcf1 Mon Sep 17 00:00:00 2001 From: Tobias Brunner Date: Thu, 30 Sep 2021 15:16:48 +0200 Subject: [PATCH] swanctl: Clear config from memory The 'secrets' section in the config file may contain passwords/PINs. --- src/swanctl/commands/load_all.c | 2 +- src/swanctl/commands/load_authorities.c | 2 +- src/swanctl/commands/load_conns.c | 2 +- src/swanctl/commands/load_creds.c | 2 +- src/swanctl/commands/load_pools.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/swanctl/commands/load_all.c b/src/swanctl/commands/load_all.c index d0032467a..1b1cf2a8f 100644 --- a/src/swanctl/commands/load_all.c +++ b/src/swanctl/commands/load_all.c @@ -86,7 +86,7 @@ static int load_all(vici_conn_t *conn) ret = load_conns_cfg(conn, format, cfg); } - cfg->destroy(cfg); + cfg->destroy_clear(cfg); return ret; } diff --git a/src/swanctl/commands/load_authorities.c b/src/swanctl/commands/load_authorities.c index 832509bf4..95a29f7dd 100644 --- a/src/swanctl/commands/load_authorities.c +++ b/src/swanctl/commands/load_authorities.c @@ -345,7 +345,7 @@ static int load_authorities(vici_conn_t *conn) ret = load_authorities_cfg(conn, format, cfg); - cfg->destroy(cfg); + cfg->destroy_clear(cfg); return ret; } diff --git a/src/swanctl/commands/load_conns.c b/src/swanctl/commands/load_conns.c index 47e434956..76d78a0d7 100644 --- a/src/swanctl/commands/load_conns.c +++ b/src/swanctl/commands/load_conns.c @@ -462,7 +462,7 @@ static int load_conns(vici_conn_t *conn) ret = load_conns_cfg(conn, format, cfg); - cfg->destroy(cfg); + cfg->destroy_clear(cfg); return ret; } diff --git a/src/swanctl/commands/load_creds.c b/src/swanctl/commands/load_creds.c index c6c24d233..3c58f3bdc 100644 --- a/src/swanctl/commands/load_creds.c +++ b/src/swanctl/commands/load_creds.c @@ -990,7 +990,7 @@ static int load_creds(vici_conn_t *conn) ret = load_creds_cfg(conn, format, cfg, clear, noprompt); - cfg->destroy(cfg); + cfg->destroy_clear(cfg); return ret; } diff --git a/src/swanctl/commands/load_pools.c b/src/swanctl/commands/load_pools.c index a3bbcfd3a..f698c07c7 100644 --- a/src/swanctl/commands/load_pools.c +++ b/src/swanctl/commands/load_pools.c @@ -285,7 +285,7 @@ static int load_pools(vici_conn_t *conn) ret = load_pools_cfg(conn, format, cfg); - cfg->destroy(cfg); + cfg->destroy_clear(cfg); return ret; }