From d4803253574e698327a689a8b771a98bab4ae092 Mon Sep 17 00:00:00 2001 From: Denozordec Date: Fri, 4 Sep 2026 11:51:53 +0700 Subject: [PATCH] Refactor: Remove unnecessary eslint-disable comments and improve code clarity in data grid components and hooks --- .../components/reui/data-grid/data-grid-column-header.tsx | 1 - apps/web/src/components/reui/data-grid/data-grid-table.tsx | 2 -- apps/web/src/components/reui/data-grid/data-grid.tsx | 5 ----- apps/web/src/hooks/use-file-upload.ts | 1 + apps/web/src/lib/breadcrumbs.ts | 3 ++- 5 files changed, 3 insertions(+), 9 deletions(-) diff --git a/apps/web/src/components/reui/data-grid/data-grid-column-header.tsx b/apps/web/src/components/reui/data-grid/data-grid-column-header.tsx index 3b746f4..b391295 100644 --- a/apps/web/src/components/reui/data-grid/data-grid-column-header.tsx +++ b/apps/web/src/components/reui/data-grid/data-grid-column-header.tsx @@ -258,7 +258,6 @@ function DataGridColumnHeaderInner({ } return items - // eslint-disable-next-line react-hooks/exhaustive-deps }, [ filter, canSort, diff --git a/apps/web/src/components/reui/data-grid/data-grid-table.tsx b/apps/web/src/components/reui/data-grid/data-grid-table.tsx index 490fd74..a9910b2 100644 --- a/apps/web/src/components/reui/data-grid/data-grid-table.tsx +++ b/apps/web/src/components/reui/data-grid/data-grid-table.tsx @@ -464,10 +464,8 @@ function DataGridTableBase({ children }: { children: ReactNode }) { colSizes[`--col-${header.column.id}-size`] = header.column.getSize() } return colSizes - // eslint-disable-next-line react-hooks/exhaustive-deps }, [ props.tableLayout?.columnsResizable, - // eslint-disable-next-line react-hooks/exhaustive-deps table.getState().columnSizing, ]) diff --git a/apps/web/src/components/reui/data-grid/data-grid.tsx b/apps/web/src/components/reui/data-grid/data-grid.tsx index df6fe0e..226a481 100644 --- a/apps/web/src/components/reui/data-grid/data-grid.tsx +++ b/apps/web/src/components/reui/data-grid/data-grid.tsx @@ -10,7 +10,6 @@ import { import { cn } from "@cdnmanager/ui/lib/utils" declare module "@tanstack/react-table" { - // eslint-disable-next-line @typescript-eslint/no-unused-vars interface ColumnMeta { headerTitle?: string headerClassName?: string @@ -108,7 +107,6 @@ export interface DataGridProps { } const DataGridContext = createContext< - // eslint-disable-next-line @typescript-eslint/no-explicit-any DataGridContextProps | undefined >(undefined) @@ -145,7 +143,6 @@ function DataGridProvider({ recordCount: props.recordCount, isLoading: props.isLoading || false, }), - // eslint-disable-next-line react-hooks/exhaustive-deps [ table, props.recordCount, @@ -157,9 +154,7 @@ function DataGridProvider({ props.emptyMessage, props.onRowClick, props.className, - // eslint-disable-next-line react-hooks/exhaustive-deps JSON.stringify(props.tableLayout), - // eslint-disable-next-line react-hooks/exhaustive-deps JSON.stringify(props.tableClassNames), tableState.sorting, tableState.pagination, diff --git a/apps/web/src/hooks/use-file-upload.ts b/apps/web/src/hooks/use-file-upload.ts index dc31bca..0875081 100644 --- a/apps/web/src/hooks/use-file-upload.ts +++ b/apps/web/src/hooks/use-file-upload.ts @@ -272,6 +272,7 @@ export const useFileUpload = ( clearFiles, onFilesChange, onFilesAdded, + onError, ] ) diff --git a/apps/web/src/lib/breadcrumbs.ts b/apps/web/src/lib/breadcrumbs.ts index e6df965..2cc3013 100644 --- a/apps/web/src/lib/breadcrumbs.ts +++ b/apps/web/src/lib/breadcrumbs.ts @@ -24,8 +24,9 @@ export function dedupeBreadcrumbs(crumbs: BreadcrumbCrumb[]): BreadcrumbCrumb[] export function getBreadcrumbs( pathname: string, - _dynamicLabels: Record = {}, + dynamicLabels: Record = {}, ): BreadcrumbCrumb[] { + void dynamicLabels const path = pathname.replace(/\/+$/, '') || '/' if (path === '/') {